Feature-gate undo module behind input-components#113
Merged
ryanoneill merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 100 100
Lines 9545 9545
=======================================
Hits 8843 8843
Misses 702 702 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The undo module is only used by InputField and TextArea (both behind the input-components feature), but was always compiled. This produced dead-code warnings under --no-default-features. Gate the module declaration with #[cfg(feature = "input-components")] to eliminate those warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ryanoneill
force-pushed
the
fix/undo-feature-gate
branch
from
9a3de2c to
8f3fb78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pub(crate) mod undowith#[cfg(feature = "input-components")]insrc/lib.rsinput-components), but was always compiled, producing dead-code warnings under--no-default-featuresVerification
cargo check --no-default-featuresproduces zero warningscargo check --all-featuresproduces zero warningsTest plan
cargo check --no-default-features— zero warningscargo test --all-features -- undo— all 67 tests pass🤖 Generated with Claude Code